EuiFormControlLayoutCustomIcon to TS
#1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodesp
commented
May 22, 2019
| ...rest | ||
| }) => { | ||
| export interface EuiFormControlLayoutCustomIconProps { | ||
| type: IconType; |
There was a problem hiding this comment.
This changed to required as EuiIcon type is required
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
thompsongl
suggested changes
May 22, 2019
src/components/form/form_control_layout/form_control_layout_custom_icon.tsx
Outdated
Show resolved
Hide resolved
|
jenkins test this |
thompsongl
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converted EuiFormControlLayoutCustomIcon to TS
Checklist