-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Steps component #201
add Steps component #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS will need to be rewritten for this to use our usual sass variable stuff, and I'll also likely change the defined classes (like title and text) you're defining to just use existing components (like EuiTitle and EuiText).
Functionality seems ok and @cchaos or I can make those changes in a subsequent PR.
I can handle the CSS updates. |
@snide @cjcenizal Should the content of each step be more riggid? Like pre-text, commands, post-text? Or, should it just be any generic node? |
@nreese I think you want generic nodes. It's more flexible. The docs can always handle use cases for what to stuff in there (which is what I'd recommend in your examples... like showing a full instruction with code / text mixed in...etc). |
I think it's perfect the way it is now. I think more rigid components for various formats of content may belong closer to where |
@snide Do we want to be able to customize the step coloring? |
@cchaos Probably. I'm thinking more in a sense of a trackable step (ex: primary are completed steps, gray for incomplete ones...etc). We'd want to set a default though (i think the blue primary is fine for this for now). |
Created new PR, #202, that merges against feature branch instead of merging into master |
Needs some CSS work to use variable instead of hard coded colors and sizes but otherwise is complete