Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import paths for EuiTable, EuiHealth, and EuiPopover. #203

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Dec 13, 2017

This causes a bug when this dependency is consumed because files in ES5 lib will try to import the ES6 files in src. We should guard against this in the future by using something like create-react-app's ModuleScopePlugin (docs).

@cjcenizal cjcenizal merged commit 6c6a204 into elastic:master Dec 13, 2017
@cjcenizal cjcenizal deleted the bug/src-import branch December 13, 2017 00:55
@cjcenizal
Copy link
Contributor Author

@bevacqua @zinckiwi @pugnascotia Any ideas on how to protect against this reoccurring or interest/time in implementing a webpack-based solution like they did with create-react-app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant