Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) NVDA/JAWS support for EuiGlobalToastList #2055

Merged
merged 6 commits into from
Jun 20, 2019
Merged

(Accessibility) NVDA/JAWS support for EuiGlobalToastList #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac173b5
Added NVDA, JAWS support for `EuiGlobalToastList`
PhilippBaranovskiy Jun 18, 2019
1bc6317
CHANGELOG updated
PhilippBaranovskiy Jun 18, 2019
95da523
Merge branch 'master' into 1947_s
PhilippBaranovskiy Jun 18, 2019
f8bb69f
js syntax error fixed
PhilippBaranovskiy Jun 19, 2019
aa1524a
Merge branch '1947_s' of https://github.com/rockfield/eui into 1947_s
PhilippBaranovskiy Jun 19, 2019
31f724c
Merge branch 'master' into 1947_s
PhilippBaranovskiy Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Changed `EuiNavDrawerFlyout` title from `h5` to `div` ([#2040](https://github.com/elastic/eui/pull/2040))
- Converted `EuiGlobalToastList` into ARIA live region by adding `role="region"` attribute to add NVDA/JAWS support ([#2055](https://github.com/elastic/eui/pull/2055))
- Added `magnifyWithMinus` and `magnifyWithPlus` glyphs to `EuiIcon` ([2056](https://github.com/elastic/eui/pull/2056))
- Added a fully black (no matter the theme) color SASS variable `$euiColorInk` ([2060](https://github.com/elastic/eui/pull/2060))

Expand Down
6 changes: 4 additions & 2 deletions src/components/toast/__snapshots__/global_toast_list.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,20 @@
exports[`EuiGlobalToastList is rendered 1`] = `
<div
aria-label="aria-label"
aria-live="polite"
class="euiGlobalToastList testClass1 testClass2"
data-test-subj="test subject string"
role="region"
/>
`;

exports[`EuiGlobalToastList props toasts is rendered 1`] = `
<div
aria-live="polite"
class="euiGlobalToastList"
role="region"
>
<div
aria-live="polite"
class="euiToast euiToast--success euiGlobalToastListItem"
data-test-subj="a"
id="a"
Expand Down Expand Up @@ -66,7 +69,6 @@ exports[`EuiGlobalToastList props toasts is rendered 1`] = `
</div>
</div>
<div
aria-live="polite"
class="euiToast euiToast--danger euiGlobalToastListItem"
data-test-subj="b"
id="b"
Expand Down
7 changes: 0 additions & 7 deletions src/components/toast/__snapshots__/toast.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ exports[`EuiToast Props color danger is rendered 1`] = `
title="test title"
>
<div
aria-live="polite"
className="euiToast euiToast--danger"
>
<EuiScreenReaderOnly>
Expand Down Expand Up @@ -47,7 +46,6 @@ exports[`EuiToast Props color primary is rendered 1`] = `
title="test title"
>
<div
aria-live="polite"
className="euiToast euiToast--primary"
>
<EuiScreenReaderOnly>
Expand Down Expand Up @@ -88,7 +86,6 @@ exports[`EuiToast Props color success is rendered 1`] = `
title="test title"
>
<div
aria-live="polite"
className="euiToast euiToast--success"
>
<EuiScreenReaderOnly>
Expand Down Expand Up @@ -129,7 +126,6 @@ exports[`EuiToast Props color warning is rendered 1`] = `
title="test title"
>
<div
aria-live="polite"
className="euiToast euiToast--warning"
>
<EuiScreenReaderOnly>
Expand Down Expand Up @@ -170,7 +166,6 @@ exports[`EuiToast Props iconType is rendered 1`] = `
title="test title"
>
<div
aria-live="polite"
className="euiToast"
>
<EuiScreenReaderOnly>
Expand Down Expand Up @@ -234,7 +229,6 @@ exports[`EuiToast Props title is rendered 1`] = `
title="toast title"
>
<div
aria-live="polite"
className="euiToast"
>
<EuiScreenReaderOnly>
Expand Down Expand Up @@ -272,7 +266,6 @@ exports[`EuiToast Props title is rendered 1`] = `
exports[`EuiToast is rendered 1`] = `
<div
aria-label="aria-label"
aria-live="polite"
class="euiToast testClass1 testClass2"
data-test-subj="test subject string"
>
Expand Down
2 changes: 2 additions & 0 deletions src/components/toast/global_toast_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ export class EuiGlobalToastList extends Component<

return (
<div
aria-live="polite"
role="region"
ref={element => {
this.listElement = element;
}}
Expand Down
2 changes: 1 addition & 1 deletion src/components/toast/toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const EuiToast: FunctionComponent<EuiToastProps> = ({
}

return (
<div className={classes} aria-live="polite" {...rest}>
<div className={classes} {...rest}>
<EuiScreenReaderOnly>
<p>
<EuiI18n
Expand Down