Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centered the square of the popout icon in the artboard #2120

Merged
merged 3 commits into from
Jul 15, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jul 12, 2019

Caroline's being nit-picky again

I noticed in Kibana when using this icon next to text, the fact that the whole path was centered in the artboard made the icon look off0centered.

Screen Shot 2019-07-12 at 15 45 48 PM

I find that the square is the most dominant shape and should be centered in the Artboard

Uncentered (before) vs Centered (after)

Screen Shot 2019-07-12 at 16 04 50 PM

So now it lines up with the text better (Top being the before)

Screen Shot 2019-07-12 at 15 46 48 PM

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cchaos cchaos merged commit 0e8c8f5 into elastic:master Jul 15, 2019
@cchaos cchaos deleted the popout-x-3 branch July 15, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants