Fix global filter truncation #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 1, 2019 18:12
by removing`box-sizing: content-box` which removes the need for calc’d max-widths and fix the flex on teh child button
thompsongl
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Verified it works in IE11 and still works in the evergreens.
Unless @snide recalls a reason not to move forward, this LGTM
snide
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Most of these fixes will need to be repeated in Kibana
I agree this is minor enough we don't need to call this breaking, Let's just make sure to remember this when we build the next release.
Generally we've made an issue in EUI as a reminder (which is how we've handled backports). I'd recommend making one when you merge.
Code looks fine.
|
I'm going to assign myself to elastic/kibana#35225 and make a comment/note in there to migrate those fixes to Kibana. |
3 tasks
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* [Pattern] Fix truncation of global filters * Fix EuiBadge truncation (esp in IE) by removing`box-sizing: content-box` which removes the need for calc’d max-widths and fix the flex on teh child button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the other half of #2189 and elastic/kibana#35225
... also finishes the fixes in #2190 for IE by:
Removes
box-sizing: content-boxfrom EuiBadge@snide If you can recall why that was in there I will try to find another solution. But that part of the styles was really conflicting with IE and forcing all those max-width calcs. Instead, I removed that to fallback to
border-boxand now just settingmax-width: 100%accounts for all the extras.Fixes the truncation of global filters
BEFORE
AFTER
Firefox
IE
Most of these fixes will need to be repeated in Kibana 😓 but atleast this diff will tell us exactly what to do and we'll need the badge fix in there first.
Checklist
[ ] Checked in dark mode[ ] Props have proper autodocs[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes