Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow self-referencing/recursive ts types #2214

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

chandlerprall
Copy link
Contributor

Summary

@daveyholler encountered this bug while working on a recursive tree component. The types->proptypes generator would infinite recurse if an interface or type referenced itself, e.g.

interface Foo {
  children: Foo[];
}

This adds a check to verify we don't follow recursive references - for now this is done by resolving to a PropTypes.any as the object we would want to refer to doesn't exist (the JS code can't self-reference).

I verified this doesn't impact any existing components' proptypes by diffing the es and lib directories before and after the change.

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
    - [ ] A changelog entry exists and is marked appropriately

Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandlerprall chandlerprall merged commit 9a33fb4 into elastic:master Aug 9, 2019
@chandlerprall chandlerprall deleted the bug/recursive-ts-types branch August 9, 2019 15:31
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants