Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center align logos #2246

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Aug 22, 2019

Fixes #2244

Summary

Center align the SIEM, Logging, and ECE logos; remove cruft.

After

Screenshot 2019-08-22 08 26 39

Screenshot 2019-08-22 08 26 31

Screenshot 2019-08-22 08 33 29

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@ryankeairns ryankeairns marked this pull request as ready for review August 22, 2019 13:42
@snide
Copy link
Contributor

snide commented Aug 22, 2019

cc @MichaelMarcialis

@MichaelMarcialis
Copy link
Contributor

Thank you, @ryankeairns! Sorry I haven't had time to tackle it myself.

@ryankeairns
Copy link
Contributor Author

No problem, I just saw the issue this morning and thought it looked like a quick fix!

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed snapshots for ya. Checked these worked. Thanks @ryankeairns

image

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryankeairns ryankeairns merged commit e336a94 into elastic:master Aug 22, 2019
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
* center align logos

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIEM logo is off-center
4 participants