Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate EuiBottomBar, EuiHealth and EuiImage to TS #2328

Merged
merged 7 commits into from
Sep 13, 2019
Merged

Migrate EuiBottomBar, EuiHealth and EuiImage to TS #2328

merged 7 commits into from
Sep 13, 2019

Conversation

pugnascotia
Copy link
Contributor

Summary

Migrate EuiBottomBar, EuiHealth and EuiImage to TS.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@snide
Copy link
Contributor

snide commented Sep 11, 2019

cc @miukimiu for awareness as I think this might conflict a bit with #2287

@pugnascotia
Migrate EuiBottomBar to TS
d7e7533
@pugnascotia
Migrate EuiHealth to TS
3d38327
@pugnascotia
Migrate EuiImage to TS
e0446e3
@pugnascotia
Update CHANGELOG
997d70c
@pugnascotia
Work around a TypeScript build problem
c17ff11 
The `yarn build` command was failing due to wierdness around the
`PADDING_SIZES` export from `bottom_bar.tsx`. Remove it, and essentially
move it to the test file, which is the only usage I could find (I
checked Kibana too).
thompsongl
thompsongl suggested changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always, @pugnascotia!

src/components/image/image.tsx Outdated Show resolved Hide resolved
src/components/image/image.tsx Show resolved Hide resolved
src/components/image/image.tsx Outdated Show resolved Hide resolved
src/components/health/health.tsx Outdated Show resolved Hide resolved
src/components/health/health.tsx Outdated Show resolved Hide resolved
@pugnascotia
Copy link
Contributor Author

Thanks @thompsongl, I've addressed your comments.

thompsongl
thompsongl suggested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this before. Need HTMLElement attributes so things like style can be spread

src/components/image/image.tsx Outdated Show resolved Hide resolved
src/components/image/image.tsx Outdated Show resolved Hide resolved
@pugnascotia
Copy link
Contributor Author

@thompsongl updated again!

thompsongl
thompsongl approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pugnascotia!

@miukimiu If this merges before #2287, I'll get you a PR that'll resolve the merge conflicts in your branch

@pugnascotia pugnascotia merged commit ea8d48e into elastic:master Sep 13, 2019
@pugnascotia pugnascotia deleted the i-cant-even-typescript branch September 13, 2019 20:46
@thompsongl thompsongl mentioned this pull request Sep 13, 2019
Merged
9 tasks
@cchaos cchaos mentioned this pull request Sep 18, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pugnascotia @snide @thompsongl