Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stacked chart icons #2379

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Add stacked chart icons #2379

merged 1 commit into from
Sep 26, 2019

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Sep 25, 2019 •
edited
Loading

Summary

Add three new stacked chart icons which are variations on existing icons: visAreaStacked, visBarVerticalStacked, and visBarHorizontalStacked.

Light and dark

Screenshot 2019-09-25 16 59 45

Screenshot 2019-09-25 16 59 20

Sketch

(the peaks and valleys on the area chart align between the top and bottom series)

Screenshot 2019-09-25 17 01 02

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@ryankeairns ryankeairns marked this pull request as ready for review September 25, 2019 22:10
cchaos
cchaos approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ryankeairns ryankeairns merged commit 313ff91 into elastic:master Sep 26, 2019
@cchaos cchaos mentioned this pull request Sep 27, 2019
Merged
snide pushed a commit to snide/eui that referenced this pull request Oct 10, 2019
@ryankeairns @snide
add stacked chart icons (elastic#2379)
68c8d3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryankeairns @cchaos