Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate EuiBreadcrumbs, EuiHeader and children, and EuiLink to TS #2391

Merged
merged 5 commits into from
Oct 4, 2019
Merged

Migrate EuiBreadcrumbs, EuiHeader and children, and EuiLink to TS #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
937ccc3
Migrate EuiBreadcrumbs, EuiHeader and children, and EuiLink to TS
pugnascotia Oct 1, 2019
ff184e5
Address review feedback
pugnascotia Oct 2, 2019
4cd8065
allow ReactNode as breadcrumb children
thompsongl Oct 2, 2019
ab83764
euilink interface exports
thompsongl Oct 2, 2019
d1093f3
Merge branch 'master' into raiders-of-the-lost-ts
pugnascotia Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Update Elastic-Charts to version 13.0.0 and updated the theme object accordingly ([#2381](https://github.com/elastic/eui/pull/2381))
- Added new `EuiColorStops` component ([#2360](https://github.com/elastic/eui/pull/2360))
- Added `currency` glyph to 'EuiIcon' ([#2398](https://github.com/elastic/eui/pull/2398))
- Migrate `EuiBreadcrumbs`, `EuiHeader` etc, and `EuiLink` to TypeScript ([#2391](https://github.com/elastic/eui/pull/2391))

**Bug fixes**

Expand Down
28 changes: 1 addition & 27 deletions ...bs/__snapshots__/breadcrumbs.test.js.snap → ...s/__snapshots__/breadcrumbs.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,14 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
data-test-subj="breadcrumbsAnimals"
href="#"
rel="noreferrer"
title="[object Object]"
>
<span>
Animals
</span>
Animals
</a>
<div
class="euiBreadcrumbSeparator"
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Reptiles"
type="button"
>
Reptiles
Expand All @@ -34,7 +30,6 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
class="euiLink euiLink--subdued euiBreadcrumb euiBreadcrumb--truncate"
href="#"
rel="noreferrer"
title="Boa constrictor"
>
Boa constrictor
</a>
Expand All @@ -44,7 +39,6 @@ exports[`EuiBreadcrumbs is rendered 1`] = `
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand All @@ -58,7 +52,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Animals"
type="button"
>
Animals
Expand All @@ -68,7 +61,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Reptiles"
type="button"
>
Reptiles
Expand All @@ -78,7 +70,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Boa constrictor"
type="button"
>
Boa constrictor
Expand All @@ -89,7 +80,6 @@ exports[`EuiBreadcrumbs props max doesn't break when max exceeds the number of b
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand All @@ -112,7 +102,6 @@ exports[`EuiBreadcrumbs props max renders 1 item 1`] = `
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand All @@ -126,7 +115,6 @@ exports[`EuiBreadcrumbs props max renders 2 items 1`] = `
>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Animals"
type="button"
>
Animals
Expand All @@ -145,7 +133,6 @@ exports[`EuiBreadcrumbs props max renders 2 items 1`] = `
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand All @@ -159,7 +146,6 @@ exports[`EuiBreadcrumbs props max renders 3 items 1`] = `
>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Animals"
type="button"
>
Animals
Expand All @@ -177,7 +163,6 @@ exports[`EuiBreadcrumbs props max renders 3 items 1`] = `
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Boa constrictor"
type="button"
>
Boa constrictor
Expand All @@ -188,7 +173,6 @@ exports[`EuiBreadcrumbs props max renders 3 items 1`] = `
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand All @@ -202,7 +186,6 @@ exports[`EuiBreadcrumbs props render a popover is rendered 1`] = `
>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Animals"
type="button"
>
Animals
Expand Down Expand Up @@ -239,7 +222,6 @@ exports[`EuiBreadcrumbs props render a popover is rendered 1`] = `
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand All @@ -253,7 +235,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Animals"
type="button"
>
Animals
Expand All @@ -263,7 +244,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Reptiles"
type="button"
>
Reptiles
Expand All @@ -273,7 +253,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Boa constrictor"
type="button"
>
Boa constrictor
Expand All @@ -284,7 +263,6 @@ exports[`EuiBreadcrumbs props responsive is rendered 1`] = `
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand All @@ -298,7 +276,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Animals"
type="button"
>
Animals
Expand All @@ -308,7 +285,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Reptiles"
type="button"
>
Reptiles
Expand All @@ -318,7 +294,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
/>
<button
class="euiLink euiLink--subdued euiBreadcrumb"
title="Boa constrictor"
type="button"
>
Boa constrictor
Expand All @@ -329,7 +304,6 @@ exports[`EuiBreadcrumbs props truncate as false is rendered 1`] = `
<span
aria-current="page"
class="euiBreadcrumb euiBreadcrumb--last"
title="Edit"
>
Edit
</span>
Expand Down
6 changes: 3 additions & 3 deletions ...omponents/breadcrumbs/breadcrumbs.test.js → ...mponents/breadcrumbs/breadcrumbs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ describe('EuiBreadcrumbs', () => {
test('is rendered', () => {
const breadcrumbs = [
{
text: <span>Animals</span>,
text: 'Animals',
href: '#',
onClick: e => {
onClick: (e: React.MouseEvent) => {
e.preventDefault();
console.log('You clicked Animals');
},
Expand All @@ -19,7 +19,7 @@ describe('EuiBreadcrumbs', () => {
},
{
text: 'Reptiles',
onClick: e => {
onClick: (e: React.MouseEvent) => {
e.preventDefault();
console.log('You clicked Reptiles');
},
Expand Down
Loading