Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Update Observability app icons #2430

Merged
merged 8 commits into from
Oct 16, 2019
Merged

[Icon] Update Observability app icons #2430

merged 8 commits into from
Oct 16, 2019

Conversation

formgeist
Copy link
Contributor

@formgeist formgeist commented Oct 15, 2019

Summary

Updating the app icons for Metrics (previously Infrastructure) and Logs to make them consistent with their solution logos, as it's the case with the other Observability apps (Code and APM).

  • Update Metrics icon

Screenshot 2019-10-15 at 14 43 56

Screenshot 2019-10-15 at 14 44 04

  • Update Logs icon

Screenshot 2019-10-16 at 09 23 20

Screenshot 2019-10-16 at 09 23 15

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Replaced the existing Infra app icon with the new metrics.
@formgeist
Copy link
Contributor Author

formgeist commented Oct 15, 2019

@snide What would be the process for changing the variable name from infraApp to metricsApp due to the rename? Just update the parameter in the used places in Kibana in a single PR?

@formgeist formgeist changed the title [Icon] Update Observability app icons [Icon][WIP] Update Observability app icons Oct 15, 2019
@snide snide mentioned this pull request Oct 15, 2019
4 tasks
@snide
Copy link
Contributor

snide commented Oct 15, 2019

I got ya, just feed the icons in. Is there one for logging as well? #2431

@snide
Copy link
Contributor

snide commented Oct 15, 2019

And yes, if you want to change the name, we'll just need to change that in the Kibana PR when we merge it. I can remember that as well. We'll ignore it as a breaking change because that logo is super specific.

@snide snide added the blocked label Oct 15, 2019
@formgeist
Copy link
Contributor Author

Sounds good @snide - thanks!

Replacing the existing loggingApp icon and renamed to make it consistent with its solution name.
Make it consistent with its solution name.
@formgeist formgeist changed the title [Icon][WIP] Update Observability app icons [Icon] Update Observability app icons Oct 16, 2019
@formgeist formgeist requested a review from snide October 16, 2019 07:52
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previewed locally including the nav drawer page and everything looks good. File changes look correct, as well.

@formgeist
Copy link
Contributor Author

@ryankeairns Thanks for doing a review. I'll merge now

@formgeist formgeist removed the request for review from snide October 16, 2019 13:28
@formgeist formgeist merged commit 1154905 into elastic:master Oct 16, 2019
@formgeist formgeist deleted the update-metrics-logs-app-icons branch October 16, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants