Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the tables' listing of onSelectionChanged -> onSelectionChange #2433

Conversation

chandlerprall
Copy link
Contributor

Summary

Resolves #2432

Corrected the props' docs for selection.onSelectionChange in tables. There are other instances of onSelectionChanged remaining in some test files but these are already addressed in #2428

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes
- [ ] A changelog entry exists and is marked appropriately

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thompsongl
Copy link
Contributor

jenkins test this

1 similar comment
@thompsongl
Copy link
Contributor

jenkins test this

@chandlerprall chandlerprall merged commit fab513d into elastic:master Oct 16, 2019
@chandlerprall chandlerprall deleted the bug/2432-incorrect-selection-props-docs branch October 16, 2019 14:49
@chandlerprall chandlerprall mentioned this pull request Oct 16, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiBasicTable selection onSelectionChange vs onSelectionChanged
2 participants