Export missing type definitions

[thompsongl]

Summary

Exports formerly exported types:

• ButtonSize
• ButtonIconSide
• EmptyButtonColor (now EuiEmptyButtonColor) [now EuiButtonEmptyColor]
• EmptyButtonSizes (now EuiEmptyButtonSizes) [now EuiButtonEmptySizes ]
• ButtonIconColor (now EuiButtonIconColor)
• EuiLinkColor
• EuiLinkType

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes

• A changelog entry exists and is marked appropriately

[bevacqua]

In Cloud UI linter is also complaining about ButtonIconSide, EmptyButtonSizes, and ButtonIconColor

[chandlerprall]

Tested with yarn build and received the error

eui.d.ts:3129:35 - error TS2307: Cannot find module '@elastic/eui/src/components/button'.
3129  export const ICON_SIDES: import ("@elastic/eui/src/components/button").ButtonIconSide[];

line 3129 is

export const ICON_SIDES: import ("@elastic/eui/src/components/button").ButtonIconSide[];

from

declare module '@elastic/eui/src/components/badge/badge' {

I'm looking into this further.

[thompsongl]

This rings a bell. The d.ts generator attempts to reuse types if they are identical (or something like that)

[chandlerprall]

The d.ts generator attempts to reuse types if they are identical (or something like that)

You appear to be correct. I don't know what layer (TypeScript or dts-generator) does that, but yep. What's happening is it tries to re-use ButtonIconSide from button/index.ts but we custom-map the index.ts files to the @elastic/eui module. Working on a fix.

[chandlerprall]

Pushed a fix for the eui.d.ts error, confirmed that it only changed the one line

13:34 $ diff eui.d.ts eui.d.ts.new
3129c3129
< 	export const ICON_SIDES: import ("@elastic/eui/src/components/button").ButtonIconSide[];
---
> 	export const ICON_SIDES: import ("@elastic/eui").ButtonIconSide[];

[chandlerprall]

Built eui.d.ts from this PR and pulled it into an empty TypeScript project. I confirmed the ability to import the added/corrected types.

import {
    ButtonSize,
    ButtonIconSide,
    EuiButtonEmptyColor,
    EuiButtonEmptySizes,
    EuiButtonIconColor,
    EuiLinkColor,
    EuiLinkType,
} from '@elastic/eui';