Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize EuiIcon #2448

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Memoize EuiIcon #2448

merged 3 commits into from
Oct 17, 2019

Conversation

chrisdavies
Copy link
Contributor

@chrisdavies chrisdavies commented Oct 17, 2019 •
edited by thompsongl
Loading

Summary

Memoize EuiIcon, which gives a pretty significant performance boost to some icon-heavy, interaction-heavy screens I'm working on in Kibana.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@chandlerprall
Copy link
Contributor

Change looks good, but needs a changelog entry.

@thompsongl
Copy link
Contributor

I'm seeing lots of Jest failures in Kibana 😕
Screen Shot 2019-10-17 at 9 56 45 AM

Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

@thompsongl
Copy link
Contributor

Ignore my last comment! The build I tested with was based on 224d9b4, before the PureComponent change.

Build with 1046186 is good 😄

@snide snide mentioned this pull request Oct 17, 2019
Closed
4 tasks
chandlerprall
chandlerprall approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, pulled and tested locally

@chrisdavies chrisdavies merged commit 35e5264 into elastic:master Oct 17, 2019
@chrisdavies chrisdavies deleted the eui/icon-memoize branch October 17, 2019 18:22
This was referenced Oct 23, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdavies @chandlerprall @thompsongl