Added horizontal scroll mixin #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miukimiu
approved these changes
Oct 22, 2019
snide
approved these changes
Oct 22, 2019
| mask-image: linear-gradient(to right, #{$gradient}); | ||
| } @else { | ||
| @warn "euiOverflowShadow() expects direction to be 'y' or 'x' but got '#{$direction}'"; |
| @@ -90,3 +90,7 @@ | |||
| .euiYScrollWithShadows { | |||
| @include euiYScrollWithShadows; | |||
| } | |||
|
|
|||
| .euiXScrollWithShadows { | |||
There was a problem hiding this comment.
I know it looks like we did this in the other one, but the rest of our utilities were written eui-. Wish these two weren't off pattern.
There was a problem hiding this comment.
We could also use a dual selector for now, and deprecate the other one. Obviously not a big deal, just something I noticed.
There was a problem hiding this comment.
Yeah so I also looked into the docs and the docs referenced this as .eui-yScrollWithShadows. I think at some point there was a bad merge that undid the change from .euiYScrollWithShadows to .eui-yScrollWithShadows. I then opted for the non-dash one, but for no particular reason but to not break that selector. I can setup a deprecation though instead.
snide
approved these changes
Oct 24, 2019
cchaos
force-pushed
the
horizontal-scroll-mixin
branch
from
f4ac48f
to
5974565
Compare
added 9 commits
October 24, 2019 16:44
Set `.euiYScroll…` for deprecation
cchaos
force-pushed
the
horizontal-scroll-mixin
branch
from
5974565
to
010f631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2215
This new mixin
euiXScrollWithShadowsand utility class.euiXScrollWithShadowscompliment the already existing mixineuiYScrollWithShadowsand utility class.euiYScrollWithShadows.Checklist
IE11and Firefox (IE doesn't support masks, and we're ok with no fallback)[ ] Props have proper autodocs[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes