Fixed position of EuiCodeBlock controls #2459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep noticing that the controls would stay in one location no matter how you changed the
paddingSize
of the EuiCodeBlock.Before example:
This PR, adjusts that position based on the padding size.
After example:
Note: The docs change is just temporary to quickly showcase the different examples. I'll revert before merging.
Also,
I beefed up the tests. At the time there was only a single "it renders" test. This adds more for each prop.
Checklist
[ ] Props have proper autodocs[ ] Added documentation examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes