Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-virtualized to 9.21.2 #2531

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Upgrade react-virtualized to 9.21.2 #2531

merged 1 commit into from
Nov 14, 2019

Conversation

bevacqua
Copy link
Contributor

@bevacqua bevacqua commented Nov 14, 2019 •
edited
Loading

React 16.11.x was complaining about Grid, inside List, inside react-virtualized, inside @elastic/eui.

chandlerprall
chandlerprall approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

@bevacqua bevacqua merged commit 95ab386 into elastic:master Nov 14, 2019
@bevacqua bevacqua deleted the upgrade-react-virtualized-because-lifecycles branch November 14, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bevacqua @chandlerprall