Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATA GRID] Avoid schema detection on columns which already have a schema #2550

Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Nov 20, 2019

Summary

Fixes #2460

Avoids running schema-detection on columns which already have a schema.

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Using Set was neat

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'm still seeing this broken? To replicate

Go to the schema docs

  • Note that the datetime column still shows as a string.
  • Also note that the icon no longer shows for the custom schema. It should be a star.

image

@chandlerprall
Copy link
Contributor Author

@snide thanks! Fixes for those are pushed - only the detected schema was passed to the sorting dropdown, instead of the whole detected+provided schema.

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now!

@chandlerprall chandlerprall merged commit 7a4efab into elastic:master Nov 21, 2019
@chandlerprall chandlerprall deleted the bug/2460-datagrid-schema-usage branch November 21, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DATA GRID] Schema needs to respect user defined schema over the detector
3 participants