Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiColorStops drag updates #2557

Merged
merged 6 commits into from
Jan 27, 2020
Merged

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Nov 22, 2019

Summary

Closes #2498.

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@thompsongl
Copy link
Contributor Author

@nreese Can you give these updates a try and see if the sluggishness you described is at all resolved?
These fairly simple changes help, but I've noticed that having the Chrome dev tools open significantly impacts drag delay.

@snide
Copy link
Contributor

snide commented Jan 24, 2020

@nreese This one has been sitting for awhile. Do you mind jumping in for a quick review?

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
passing the same function references instead of creating new functions should limit down stream renders. Seams like a good place to start with performance improvements.

@thompsongl thompsongl marked this pull request as ready for review January 27, 2020 19:06
@thompsongl thompsongl merged commit 60a3cbd into elastic:master Jan 27, 2020
@thompsongl thompsongl deleted the 2498-drag-perf branch January 27, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiColorStops] throttle EuiColorStop interactions
3 participants