Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds background-color to compressed button group #2568

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Nov 26, 2019

Fixes #2564

Summary

Adds background color to compressed button groups to prevent underlying background from showing through. Also, reduced the tint on 'selected' button background color for a touch more contrast.

As you'll see below, these minor changes result in the button groups also aligning better to the styles of the other compressed inputs.

Before (left) and After (right)

Artboard

With Canvas sidebar background color

Screenshot 2019-11-26 16 37 56

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@ryankeairns ryankeairns marked this pull request as ready for review November 26, 2019 22:52
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better and even the dark mode selection is more visible. Just had a minor comment but really it's good to go.

src/components/form/_variables.scss Outdated Show resolved Hide resolved
@ryankeairns ryankeairns merged commit a845a2a into elastic:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discuss] Compressed input contrast
2 participants