-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated axe testing #2569
Automated axe testing #2569
Conversation
I'll take a look today |
^ #2588 has what I think is the right way to fix the duplicate |
Overall, these changes look good. I haven't reviewed a11y-testing.js or the readme changes in depth yet, but everything looks good functionally. A blocker for this moving forward is CI's failure when running
which demonstrates both a failure to run puppeteer and that the error didn't fail the CI job, instead it crashed "silently". |
e7387c5
to
38b1e93
Compare
38b1e93
to
338999f
Compare
Just an update: I've been working on some Docker and script changes to get the necessary deps into EUI CI runs. Learning some things and getting closer to understanding what the limitations are. I'll continue to with infra to get this going. |
jenkins test this ^ Last commit works in Docker locally, so I suspect some user/permission thing with the Jenkins setup |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this Going trigger a few more builds to see about stability. The recent change is to run Chromium without a sandbox, which is generally only acceptable in cases like this where we fully own the content being crawled. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
I'm going to call this "stable enough" and do some clean up 🎉 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
Ready for your review, @chandlerprall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGreatTM, pulled & tested locally in both a passing & error states, with both the automated test server on port 9999 & against the local development server.
😅 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2569/ |
Summary
Closes #2231 and introduces automated axe testing!
Currently only testing the guidelines so the capability can be merged. Adding more pages over time can become a ticket an a few pages can be added at a time when people have spare cycles. (For reference, there are currently 84 errors found when running it across all pages. This does not count color contrast rules which had to be disabled due to their quantity...)
Run
npm run start-test-server-and-a11y-test
to run the tests locally.TODO
test
script)id
onEuiFormRow
wrapping element #2588 to address this)Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately