Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Grid] made numeric sorting look at the full field value #2603

Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Dec 6, 2019

Summary

Fixes #2465

Instead of sorting by the first float value found in a numerical value, this changes data grid's numeric sorting to find and use all groups of numeric digits when comparing two cell values.

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My JS regex / math isn't strong enough to review the code side, but functionally this works how I'd expect.

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chandlerprall chandlerprall merged commit 53880eb into elastic:master Dec 9, 2019
@chandlerprall chandlerprall deleted the datagrid/2465-numeric-sorting branch December 9, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DATA GRID] Sorting of numeric data only goes to first period
3 participants