Initialize EuiCodeEditor
with existing mode
#2616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work in #2577 happened upon a 404 error related custom modes in
EuiCodeEditor
(and prevents its docs from building statically). When setting a custom mode,EuiCodeEditor
would initialize without a mode and usesetMode
oncomponentDidMount
, resulting in an attempt to fetch[some_path]/mode-mode.js
, which does not exist (error visible in prod docs, also).The
react-ace
docs specify that the component should be initialized with an existing mode prior to setting the custom mode. This prevents the fetch of a nonexistent mode file.Fixes #2524
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes