Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiComboBox prevent form submission #2642

Merged
merged 2 commits into from
Dec 12, 2019
Merged

EuiComboBox prevent form submission #2642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e56d64
preventDefault
thompsongl Dec 12, 2019
f50a014
CL
thompsongl Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
**Bug fixes**

- Fixed `EuiDroppable` not accepting multiple children when using TypeScript ([#2634](https://github.com/elastic/eui/pull/2634))
- Fixed `EuiComboBox` from submitting parent `form` element when selecting options via `Enter` key ([#2642](https://github.com/elastic/eui/pull/2642))

## [`17.1.2`](https://github.com/elastic/eui/tree/v17.1.2)

Expand Down
1 change: 1 addition & 0 deletions src/components/combo_box/combo_box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ export class EuiComboBox extends Component {
break;

case comboBoxKeyCodes.ENTER:
e.preventDefault();
e.stopPropagation();
if (this.hasActiveOption()) {
this.onAddOption(
Expand Down