Convert EuiPage and related components to TS #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
commented
Dec 13, 2019
thompsongl
suggested changes
Dec 16, 2019
src/components/page/page_content/page_content_header_section.tsx
Outdated
Show resolved
Hide resolved
Better type checking for EuiPageBody's component
thompsongl
suggested changes
Dec 18, 2019
There was a problem hiding this comment.
Some new things, plus I missed a couple last time.
Need to export the the props types/interfaces from their respective index.ts, and from page/index.ts:
EuiPageProps
EuiPageBodyProps
EuiPageContentProps
EuiPageContentBodyProps
EuiPageContentHeaderProps
EuiPageContentHeaderSectionProps
EuiPageHeaderProps
EuiPageHeaderSectionProps
EuiPageSideBarProps
|
Thanks @thompsongl. All the props should be exported now. Feedback addressed. Thanks for walking me through this one! |
|
jenkins test this flaky test, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2646
Converts the following components to TS
Checklist
Checked in dark modeChecked in mobileChecked in IE11 and FirefoxAdded documentation examplesChecked for accessibility including keyboard-only and screenreader modes