Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiFieldPassword: converted to Typescript #2683

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

ffknob
Copy link
Contributor

@ffknob ffknob commented Dec 17, 2019

Summary

Closes #2650
Converted EuiFieldPassword to Typescript.

Checklist

  • Check against all themes for compatability in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ffknob!

Also, you can remove the TS reference in src/components/form/index.d.ts line 3:
/// <reference path="./field_password/index.d.ts" />
and then delete the ./field_password/index.d.ts file as it is no longer needed

@thompsongl
Copy link
Contributor

jenkins test this

@thompsongl thompsongl merged commit 68a7f27 into elastic:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiFieldPassword needs to be converted to TS
4 participants