Added a small version of the EuiCallOut #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
suggested changes
Jan 8, 2018
There was a problem hiding this comment.
@cchaos Grat.Can you bump the size of the child paragraphs down on the off chance they use them as well. That way they're still usable if people need small messages.
Think that makes sense. Right now it looks a little weird if you use more than just the title (which, granted I'm guessing won't be often).
Something like this?
|
I'm not really sure it needed to, but I did anyway. This is a screenshot of what it would look like with children, though I took out the children from the actual example.
|
snide
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: elastic/kibana#15713
The
EuiCallOutnow accepts a property ofsizewhich for now can only besormand defaults tom.I realized that just adjusting the padding of the CallOut wasn't significant enough to create a more unobtrusive component. I had to adjust the heading size as well. That is why the property is not
paddingSizebut justsizein general.