Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nested glyph to EuiIcon #2707

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Added nested glyph to EuiIcon #2707

merged 2 commits into from
Dec 20, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Dec 19, 2019 •
edited
Loading

Fixes elastic/kibana#49842

Mainly to be used in Kibana as an ES nested field type.

Screen Shot 2019-12-19 at 17 57 52 PM

Screen Shot 2019-12-19 at 17 57 06 PM

Screen Shot 2019-12-19 at 17 57 14 PM

Checklist

  • Check against all themes for compatability in both light and dark modes
  • [ ] Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos cchaos changed the title Added nested glyph to EuiIcon Added nested to EuiIcon Dec 19, 2019
@cchaos cchaos changed the title Added nested to EuiIcon Added nested glyph to EuiIcon Dec 19, 2019
snide
snide approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked code and in my non-retina browser.

ryankeairns
ryankeairns approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🔤

@cchaos cchaos merged commit 32b7bef into elastic:master Dec 20, 2019
@cchaos cchaos deleted the nested_icon branch December 20, 2019 15:36
@chandlerprall chandlerprall mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@snide snide snide approved these changes

@timroes timroes Awaiting requested review from timroes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show an icon for nested fields in discover
3 participants
@cchaos @snide @ryankeairns