Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added muted bell icon #2714

Merged
merged 8 commits into from
Jan 8, 2020
Merged

Added muted bell icon #2714

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ab0ae39
added muted bell icon
andreadelrio Dec 24, 2019
189cdea
added cl entry
andreadelrio Dec 24, 2019
c557835
updated icon and cl
andreadelrio Jan 2, 2020
23d0dbd
temporary cl update
andreadelrio Jan 6, 2020
37c6e6f
Merge remote-tracking branch 'upstream/master' into muted-bell
andreadelrio Jan 6, 2020
5b5dd49
update cl
andreadelrio Jan 6, 2020
24a5058
removed fill-rule
andreadelrio Jan 6, 2020
688b138
cl
andreadelrio Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Added `nested` glyph to `EuiIcon` ([#2707](https://github.com/elastic/eui/pull/2707))
- Added `tableLayout` prop to `EuiTable`, `EuiBasicTable` and `EuiInMemoryTable` to provide the option of auto layout ([#2697](https://github.com/elastic/eui/pull/2697))
- Added `bellMuted` glyph to `EuiIcon` ([#2714](https://github.com/elastic/eui/pull/2714))

**Bug fixes**

Expand Down
1 change: 1 addition & 0 deletions src-docs/src/views/icon/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export const iconTypes = [
'asterisk',
'beaker',
'bell',
'bellMuted',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being picky here about naming, but I think "Muted" may not be generic enough. Perhaps bellSlash instead similar to the way we name things like "empty" which is more indicating the visual of icon versus the perceived meaning.

'bolt',
'boxesHorizontal',
'boxesVertical',
Expand Down
18 changes: 18 additions & 0 deletions src/components/icon/__snapshots__/icon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,24 @@ exports[`EuiIcon props type bell is rendered 1`] = `
</svg>
`;

exports[`EuiIcon props type bellMuted is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<title />
<path
d="M9.5 14l-.005.15a2 2 0 01-3.972.153l-.018-.154L5.5 14h4zm4.323-12.882a.5.5 0 01.11.631l-.051.074-11 13a.5.5 0 01-.816-.572l.052-.074 11-13a.5.5 0 01.705-.059zm-.786 4.39l.054.356.048.368c.066.554.103.98.145 1.724l.08 1.491c.146 2.371.402 3.053 1.136 3.053a.5.5 0 110 1c-.603 0-1.031-.146-1.34-.499H5.81l.869-1h6.005c-.172-.644-.264-1.528-.33-2.708l-.09-1.638a21.742 21.742 0 00-.193-1.855l.821-.945c.06.208.107.426.145.653zM7.5 0a2 2 0 011.98 1.717c.42.1.803.234 1.152.402l-.682.787c-.46-.187-.995-.308-1.607-.366a1 1 0 10-1.684 0C4.455 2.748 3.26 3.78 2.95 5.67l-.05.334-.046.347c-.08.676-.115 1.161-.176 2.347l-.014.265c-.055 1.096-.127 1.954-.252 2.615L.75 13.49c-.08.006-.163.009-.25.009a.5.5 0 110-1c.76 0 1.008-.732 1.151-3.313l.077-1.427c.038-.626.073-1.025.134-1.528.03-.25.063-.49.102-.724.334-2.04 1.546-3.313 3.555-3.792l.004-.019A2 2 0 017.5 0z"
/>
</svg>
`;

exports[`EuiIcon props type bolt is rendered 1`] = `
<svg
aria-hidden="true"
Expand Down
15 changes: 15 additions & 0 deletions src/components/icon/assets/bellMuted.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import React from 'react';

const EuiIconBellMuted = ({ title, ...props }) => (
<svg
width={16}
height={16}
viewBox="0 0 16 16"
xmlns="http://www.w3.org/2000/svg"
{...props}>
<title>{title}</title>
<path d="M9.5 14l-.005.15a2 2 0 01-3.972.153l-.018-.154L5.5 14h4zm4.323-12.882a.5.5 0 01.11.631l-.051.074-11 13a.5.5 0 01-.816-.572l.052-.074 11-13a.5.5 0 01.705-.059zm-.786 4.39l.054.356.048.368c.066.554.103.98.145 1.724l.08 1.491c.146 2.371.402 3.053 1.136 3.053a.5.5 0 110 1c-.603 0-1.031-.146-1.34-.499H5.81l.869-1h6.005c-.172-.644-.264-1.528-.33-2.708l-.09-1.638a21.742 21.742 0 00-.193-1.855l.821-.945c.06.208.107.426.145.653zM7.5 0a2 2 0 011.98 1.717c.42.1.803.234 1.152.402l-.682.787c-.46-.187-.995-.308-1.607-.366a1 1 0 10-1.684 0C4.455 2.748 3.26 3.78 2.95 5.67l-.05.334-.046.347c-.08.676-.115 1.161-.176 2.347l-.014.265c-.055 1.096-.127 1.954-.252 2.615L.75 13.49c-.08.006-.163.009-.25.009a.5.5 0 110-1c.76 0 1.008-.732 1.151-3.313l.077-1.427c.038-.626.073-1.025.134-1.528.03-.25.063-.49.102-.724.334-2.04 1.546-3.313 3.555-3.792l.004-.019A2 2 0 017.5 0z" />
</svg>
);

export const icon = EuiIconBellMuted;
3 changes: 3 additions & 0 deletions src/components/icon/assets/bellMuted.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/components/icon/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const typeToPathMap = {
auditbeatApp: 'app_auditbeat',
beaker: 'beaker',
bell: 'bell',
bellMuted: 'bellMuted',
bolt: 'bolt',
boxesHorizontal: 'boxes_horizontal',
boxesVertical: 'boxes_vertical',
Expand Down