Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beta] Add EuiTour component #2766
[Beta] Add EuiTour component #2766
Changes from 34 commits
40639c7
ffc3e89
0ceae7b
5e9fc3b
306d3f6
ae2d613
6f0b03c
7a2ade7
ab7bf20
8cd9369
84729de
84d1abe
9f9881f
892564b
02aaf74
8ec84d5
5bb4bcd
ad1e765
9332125
70904b5
0e21359
a1fde1f
224ca9a
f4299e0
e24f906
6ac82d9
d0f94ea
2a1cf69
d64e69c
d484a17
7af1fd7
3f45c0a
7734089
429df67
00c4f10
0885e8e
28973de
8a2d4b1
4ce53d7
a4f1b21
c9e3744
b43d043
3f2becf
a07696b
3764ec6
9e32bbd
5e19c19
bd9587e
53d53dd
71ed1e7
7cf9aff
88699d8
293bd6a
b9c7642
6f51b83
cf90dde
86fb015
341a359
4ccb005
cb318a9
6b17460
75c0d42
7b3ec39
964465a
a3dc4e1
a5f6cf8
02e6951
11ef87f
71f31cb
2b26855
2e91eb2
8d846bf
b4bd1db
59a41d2
50170b8
87b96f5
25020b3
eb4a77b
6519148
ac39673
480ead2
a301ff7
89a1394
d748e8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thompsongl was it intentional to leave these
console.log
statements in here (there are two more that start with'Updating localstorage'
)? I found it strange/surprising that it logs on production (well, on the EUI docs site, haha).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha nope. We should remove these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
luckily, I made the branch that fixes this last night :) #3513