Set viewBox for icons that have not set it #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the viewBox for SVG files that did not already have it set, which was stopping them from being resized properly in Chrome.
|
I think these were all my exports :( I used SVGO in the command line to optimize them and I think it removed the viewboxes. I'll try the SVGO Sketch plugin next time. |
|
Thank you! LGTM, but the tests need to be updates. Most likely you'll need to clear your test cache first. |
cchaos
approved these changes
Jan 9, 2018
pickypg
added a commit
that referenced
this pull request
Jan 10, 2018
pickypg
added a commit
that referenced
this pull request
Jan 10, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the viewBox for SVG files that did not already have it set, which was stopping them from being resized properly in Chrome.
Closes #276