Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert EuiSuperSelect to TS #2776

Merged
merged 10 commits into from
Jan 24, 2020
Merged

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jan 17, 2020

Summary

Closes #2651

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox

  • Props have proper autodocs

- [ ] Added documentation examples

  • Added or updated jest tests

- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, one ask that I hope doesn't become too big

src/components/form/super_select/super_select.tsx Outdated Show resolved Hide resolved
src/components/form/super_select/super_select.tsx Outdated Show resolved Hide resolved
src/components/form/super_select/super_select.tsx Outdated Show resolved Hide resolved
src/components/form/super_select/super_select.tsx Outdated Show resolved Hide resolved
src/components/form/super_select/super_select.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Built eui.d.ts and ran type_check in Kibana without errors

@thompsongl thompsongl merged commit ecc7471 into elastic:master Jan 24, 2020
@thompsongl thompsongl deleted the superselect-ts branch January 24, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiSuperSelect needs to be converted to TS
3 participants