EuiButtonToggle/useRenderToText: prevent state update on unmounted component
#2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| requestAnimationFrame(() => { | ||
| unmountComponentAtNode(hostNode); | ||
| }); | ||
| onUnmount(); |
There was a problem hiding this comment.
👍 it's nice that the RAF trick is no longer required
andrew-goldstein
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Thanks @thompsongl for the quick turnaround on this for 7.6! 🙏
LGTM
This was referenced Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2736.
DocumentFragmentreference in a mutableuseRefobject so it's (synchronously) modifiable and available for the lifecycle duration.refcallback fromuseInnerTextis auseStatesetter, so we need to prevent invocations after unmount (hostNode == null).requestAnimationFrametick as there are no more state side-effects during the unmount process.Simple testing method with local EUI docs:
EuiCodeBlockImplwarning, but no state update warningChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes