-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headerRow to EuiBasicTable #2802
Merged
andreadelrio
merged 9 commits into
elastic:master
from
andreadelrio:EuiTableRowCell-a11y
Jan 31, 2020
Merged
Add headerRow to EuiBasicTable #2802
andreadelrio
merged 9 commits into
elastic:master
from
andreadelrio:EuiTableRowCell-a11y
Jan 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreadelrio
commented
Jan 30, 2020
From an a11y perspective, I think this is all that's needed and is good to go 👍 🎉 |
andreadelrio
force-pushed
the
EuiTableRowCell-a11y
branch
from
January 30, 2020 19:11
d590073
to
7da28d7
Compare
thompsongl
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise LGTM!
myasonik
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VoiceOver output is correct 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new prop called
headerRow
toBasicTable
that lets consumers specify what column is the row header (and thus should have<th scope=“row”>
).Doing something like
results in this markup
Limitations:
This only works with
FieldDataColumn
as it hasfield
as a required prop which is what I’m using for doing(column as EuiTableFieldDataColumnType<T>).field === headerRow
Fixes #2335 #2337
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes