Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu allow jsx #2817

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Context menu allow jsx #2817

merged 4 commits into from
Feb 3, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Feb 3, 2020 •
edited
Loading

Summary

This change will allow us to render more complex context menu items on Dashboard in Kibana, like Edit link below:

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@streamich streamich mentioned this pull request Feb 3, 2020
Merged
@chandlerprall chandlerprall self-assigned this Feb 3, 2020
@chandlerprall chandlerprall self-requested a review February 3, 2020 16:33
chandlerprall
chandlerprall suggested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled & tested locally.

Please add an entry to CHANGELOG.md for this, should be in the master section at the top, under the first group representing feature additions

@streamich
Copy link
Contributor Author

@chandlerprall Done.

@chandlerprall
Copy link
Contributor

Will merge after CI passes

@chandlerprall chandlerprall merged commit 14df13c into master Feb 3, 2020
@chandlerprall chandlerprall deleted the context_menu_allow_jsx branch February 3, 2020 19:35
@thompsongl thompsongl mentioned this pull request Feb 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees

@chandlerprall chandlerprall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streamich @chandlerprall