Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing some markdown files around contributions #2827

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 5, 2020

Based on our conversations around how to encourage PR handoffs I added a section in the CONTRIBUTING.md file. I also updated the component-design.md file to match the new TS format.

@cchaos cchaos requested review from chandlerprall and snide February 5, 2020 14:56
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. The rest looks great. Thanks for getting all the TS stuff in.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@cchaos cchaos requested a review from snide February 5, 2020 20:06
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

wiki/component-design.md Outdated Show resolved Hide resolved
Co-Authored-By: Chandler Prall <chandler.prall@gmail.com>
@cchaos cchaos requested a review from chandlerprall February 5, 2020 22:21
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fantastic, thank you @cchaos !

@cchaos cchaos merged commit e88c8c6 into elastic:master Feb 6, 2020
@cchaos cchaos deleted the contributing_md branch February 6, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants