Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added props to highlight all matches in EuiHighlight #2957

Merged
merged 12 commits into from
Mar 6, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Mar 2, 2020

Summary

Fixes #2911

  • Added props to highlight all matches in EuiHighlight

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ashikmeerankutty
Copy link
Contributor Author

@chandlerprall can you please review this?

@chandlerprall chandlerprall self-assigned this Mar 4, 2020
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs page for EuiHighlight (http://localhost:8030/#/utilities/highlight) to include a switch to turn this functionality on/off - an example of this can be found at

(http://localhost:8030/#/display/badge).

In addition, can you try to activate the Props tab for this component? This will require modifying src-docs/src/views/highlight/highlight_example.js to import EuiHighlight can add it to a props object. For reference, you can see how the Badge page's Props tab is setup at

props: { EuiBadge },

CHANGELOG.md Outdated Show resolved Hide resolved
src/components/highlight/highlight.tsx Outdated Show resolved Hide resolved
src/components/highlight/highlight.tsx Outdated Show resolved Hide resolved
src/components/highlight/highlight.tsx Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@ashikmeerankutty
Copy link
Contributor Author

@chandlerprall Changes updated. Can you please review it?

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very small requests, otherwise this looks great

src-docs/src/views/highlight/highlight.js Outdated Show resolved Hide resolved
src/components/highlight/highlight.tsx Outdated Show resolved Hide resolved
@ashikmeerankutty
Copy link
Contributor Author

@chandlerprall Fixed 👍

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled & tested docs example & props tab locally

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2957/

@chandlerprall chandlerprall merged commit cbbcc9e into elastic:master Mar 6, 2020
@ashikmeerankutty ashikmeerankutty deleted the feature/euihighlight branch April 15, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EUIHighlight highlights only first found word
3 participants