-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added props to highlight all matches in EuiHighlight #2957
Added props to highlight all matches in EuiHighlight #2957
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@chandlerprall can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the docs page for EuiHighlight
(http://localhost:8030/#/utilities/highlight) to include a switch to turn this functionality on/off - an example of this can be found at
eui/src-docs/src/views/badge/badge.js
Line 77 in fc3d292
<EuiSwitch |
In addition, can you try to activate the Props tab for this component? This will require modifying src-docs/src/views/highlight/highlight_example.js to import EuiHighlight
can add it to a props
object. For reference, you can see how the Badge page's Props tab is setup at
eui/src-docs/src/views/badge/badge_example.js
Line 117 in fc3d292
props: { EuiBadge }, |
@chandlerprall Changes updated. Can you please review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very small requests, otherwise this looks great
@chandlerprall Fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; pulled & tested docs example & props tab locally
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2957/ |
Summary
Fixes #2911
Checklist