Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed data grid sort popover #2979

Merged
merged 4 commits into from
Mar 4, 2020
Merged

fixed data grid sort popover #2979

merged 4 commits into from
Mar 4, 2020

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 4, 2020

Summary

Fixes: #2975 fixed data grid sort popover

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Some small changes. Generally responsive={false} is all you need to make something not wrap on smaller screens.

CHANGELOG.md Outdated Show resolved Hide resolved
src/components/datagrid/column_sorting.tsx Outdated Show resolved Hide resolved
src/components/datagrid/column_sorting.tsx Outdated Show resolved Hide resolved
anishagg17 and others added 2 commits March 4, 2020 20:08
Co-Authored-By: dave.snider@gmail.com <dave.snider@gmail.com>
@anishagg17
Copy link
Contributor Author

@snide all changes have been made

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@snide snide merged commit 9f823ac into elastic:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid sort popover becomes to narrow
3 participants