-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
now EuiBadge render anchor tags too #3009
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anishagg17 We will also need a new docs section below Badge with onClick events
that is Badge with href
. Can you start this docs page and we'll help flesh out the content?
Okay @cchaos |
@cchaos as button-badge which was disabled was also not listed. So, I added it too in this pr |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3009/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anishagg17 I created a PR for you: anishagg17#2 You will also need to add tests for the |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3009/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like @chandlerprall's review for TS
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; pulled and tested the docs page, particularly Badge with onClick events
Summary
Fixes : #2831
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes