Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now EuiBadge render anchor tags too #3009

Merged
merged 11 commits into from
Mar 16, 2020
Merged

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 8, 2020

Summary

Fixes : #2831

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anishagg17 We will also need a new docs section below Badge with onClick events that is Badge with href. Can you start this docs page and we'll help flesh out the content?

@anishagg17
Copy link
Contributor Author

Okay @cchaos

@anishagg17
Copy link
Contributor Author

anishagg17 commented Mar 12, 2020

@cchaos as button-badge which was disabled was also not listed. So, I added it too in this pr

@cchaos
Copy link
Contributor

cchaos commented Mar 13, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3009/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of why we document or show examples of permutations of components. To find rendering issues like having a link inside a badge.

Screen Shot 2020-03-13 at 12 57 12 PM

There's quite a bit of styling fixes needed for this one that will require a designer's touch. So I'll get you PR later today.

@cchaos
Copy link
Contributor

cchaos commented Mar 13, 2020

@anishagg17 I created a PR for you: anishagg17#2

You will also need to add tests for the href prop.

@cchaos
Copy link
Contributor

cchaos commented Mar 14, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3009/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like @chandlerprall's review for TS

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled and tested the docs page, particularly Badge with onClick events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiBadge should allow for href
4 participants