Add syncify test helper #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
force-pushed
the
add-syncify-test-helper
branch
from
969cf7c
to
bf1abf5
Compare
6 tasks
cjcenizal
approved these changes
Jan 12, 2018
src/test/syncify.js
Outdated
| @@ -0,0 +1,10 @@ | |||
| // Helper designed to help test async/await functions that throw exceptions | |||
| // https://github.com/facebook/jest/issues/1377 | |||
There was a problem hiding this comment.
Can we add your example code to this comment:
Example usage:
const fn = await syncify(() => asyncFn());
expect(fn).toThrow();
|
Oh and can you add a note to the CHANGELOG.md? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cjcenizal recommended adding this from this discussion
This helper allows you to properly test async functions that throw exceptions.
Here is working code using the helper: