-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial removal of lodash from charts, docs, selectable and datepicker components #3053
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3053/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting to dig into these!
For future changes, any dependencies on lodash
inside test files can remain. We're mainly interested in removing it as a runtime dependency.
packages/react-datepicker/docs-site/src/examples/render_custom_header.jsx
Show resolved
Hide resolved
I have made the necessary changes |
I have restored it and will remove it some other day |
Also failing from the 3 other react-datepicker modifications,
|
I have replaced it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; pulled & tested locally, including react-datepicker tests & docs
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3053/ |
Summary
Makes progress on #360
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes