Add support for node name prop to EuiTabbedContent, to bring it up to par with EuiTab #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
chore/tabbed-content-node-children
branch
from
3916c2d
to
40aa816
Compare
|
@cjcenizal This PR is against a pretty old version of EUI. Looks like v14 or so. Looks good otherwise though, I see the current version still has a string there still. |
… par with EuiTab. - Update documentation to illustrate this capability.
cjcenizal
force-pushed
the
chore/tabbed-content-node-children
branch
from
40aa816
to
8776864
Compare
|
Thanks @snide, looks like I missed a git pull! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3100/ |
13 tasks
thompsongl
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Thanks, @cjcenizal!
I came across this discrepancy last week and forgot to make an issue for it 👍
cchaos
suggested changes
Mar 17, 2020
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| - Added `useResizeObserver` hook ([#2991](https://github.com/elastic/eui/pull/2991)) | |||
| - Added `showColumnSelector.allowHide` and `showColumnSelector.allowReorder` props to `EuiDataGrid` UI configuration ([#2993](https://github.com/elastic/eui/pull/2993)) | |||
| - Added `EuiMark` component ([#3060](https://github.com/elastic/eui/pull/3060)) | |||
| - Add support for node `name` prop in `EuiTabbedContent`, to bring it on par with `EuiTab` ([#3100](https://github.com/elastic/eui/pull/3100)) | |||
There was a problem hiding this comment.
I was very confused by the title of this PR, can you change the CL to
Suggested change
| - Add support for node `name` prop in `EuiTabbedContent`, to bring it on par with `EuiTab` ([#3100](https://github.com/elastic/eui/pull/3100)) | |
| - Changed `name` prop to `ReactNode` type in `EuiTabbedContent` ([#3100](https://github.com/elastic/eui/pull/3100)) |
Co-Authored-By: Dave Snider <dave.snider@gmail.com>
cchaos
approved these changes
Mar 17, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3100/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EuiTabalready supports this, so now users ofEuiTabbedContentwill also be able to provide a node for thenameprop.Checklist
Check against all themes for compatibility in both light and dark modesChecked in mobileChecked in IE11 and FirefoxChecked for accessibility including keyboard-only and screenreader modes