-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiSuperDatePicker should show tooltip for the popover close event #3127
EuiSuperDatePicker should show tooltip for the popover close event #3127
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@ashikmeerankutty Please describe in the summary how you have fixed the issue. |
@cchaos Thanks for the review, updated the description with changes. Can you please review it. |
This is definitely a lot better than being overwhelmed by the tooltip. Two things that could make this even better, if we can get the popover stuff to function this way:
|
@chandlerprall Fixed both issues. Can you please review it now? |
Jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3127/ |
src/components/date_picker/super_date_picker/super_update_button.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; pulled & tested in the docs
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3127/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functionally. Just have one change request for the prop description.
Summary
Fixes #3124; Fixes #1708
Added
isPopoverClosed
prop toEuiSuperUpdateButton
component that will return true if both the start and end popovers are closed.If there is a change in the value and the popover is closed the tooltip is displayed.
The
showToolTip
function is not called for all update operations and is called only ifisPopoverClosed
Before
After
Checklist
- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes