Remove react-virtualized from ComboBox #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3173/ |
|
This change was requested by @chandlerprall but anyone can review |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3173/ |
thompsongl
reviewed
Apr 3, 2020
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Outdated
Show resolved
Hide resolved
chandlerprall
suggested changes
Apr 6, 2020
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Outdated
Show resolved
Hide resolved
src/components/combo_box/combo_box_options_list/combo_box_options_list.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
April 6, 2020 19:02
myasonik
force-pushed
the
cleanup-react-virtualized
branch
from
386b61e
to
3c0c49e
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3173/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3173/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3173/ |
chandlerprall
suggested changes
May 12, 2020
chandlerprall
approved these changes
May 12, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removing
react-virtualizedin favor ofreact-window.EuiSelectableandEuiComboBoxwere the only two consumers ofreact-virtualized. WithEuiSelectablemoving toreact-window, this made sense to do to drop EUI's footprint.react-windowis smaller, faster, and has better accessibility so it's pretty much a win on all fronts.Did the smallest amount of changes to make this happen but they do handle things like scrolling and item rendering a bit differently so it required a bit of code.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately