Pass title and aria attributes to EuiToken's icon element
#3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
myasonik
approved these changes
Mar 30, 2020
thompsongl
suggested changes
Mar 30, 2020
thompsongl
changed the title
EuiToken's icon element
thompsongl
approved these changes
Mar 30, 2020
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
cchaos
reviewed
Mar 30, 2020
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3195/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#3182
aria-label, aria-labelledby, aria-describedby, title is now added to EuiToken
Checklist
~~Check against all themes for compatibility in both light and dark modes
~~Checked in mobile
Added documentation examples