-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed console error in EuiDatePopoverContent #3254
Fixed console error in EuiDatePopoverContent #3254
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current change would eliminate the prop type errors, but the intention of the initialSelectedTab
prop is not quite fulfilled.
Using the date mode returned by getDateMode(value)
we could look up the correct tab item from the renderTabs()
array. That reference could be passed to initialSelectedTab
resulting in matching name
and content
values.
Also, if it's helpful to refactor, renderTabs
could possibly be just an array and not a function.
@thompsongl Thank you for the suggestion. Fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @ashikmeerankutty for your contribution.
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3254/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3254/ |
Summary
Fixes #3250
This error due to
name
andcontent
not passed to EuiTabbedContent.Checklist
- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately