Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed console error in EuiDatePopoverContent #3254

Merged

Conversation

ashikmeerankutty
Copy link
Contributor

Summary

Fixes #3250

This error due to name and content not passed to EuiTabbedContent.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
    - [ ] Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
    - [ ] A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current change would eliminate the prop type errors, but the intention of the initialSelectedTab prop is not quite fulfilled.

Using the date mode returned by getDateMode(value) we could look up the correct tab item from the renderTabs() array. That reference could be passed to initialSelectedTab resulting in matching name and content values.

Also, if it's helpful to refactor, renderTabs could possibly be just an array and not a function.

@ashikmeerankutty
Copy link
Contributor Author

@thompsongl Thank you for the suggestion. Fixed 👍

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @ashikmeerankutty for your contribution.

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3254/

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3254/

@thompsongl thompsongl merged commit 9945cbe into elastic:master Apr 7, 2020
@ashikmeerankutty ashikmeerankutty deleted the fix/super-datepicker-popover branch April 15, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type initialSelectedTab.name provided to EuiTabbedContent from EuiDatePopoverContet
4 participants