Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed focus on EuiTabbedContent when initialFocus is selected #3285

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Fixed focus on EuiTabbedContent when initialFocus is selected #3285

merged 3 commits into from
Apr 9, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Apr 9, 2020 •
edited
Loading

Summary

Fixes #3261

Fixed EuiTabbedContent doesn't focus on the correct tab when using the mouse and initialFocus is selected

This issue was fixed by calling focus after setState so the correct tab is focused.

Before:
before

After :
after

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@miukimiu
Copy link
Contributor

miukimiu commented Apr 9, 2020

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3285/

@cchaos cchaos requested a review from thompsongl April 9, 2020 15:34
thompsongl
thompsongl approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3285/

@thompsongl thompsongl merged commit d08ac11 into elastic:master Apr 9, 2020
@ashikmeerankutty ashikmeerankutty deleted the tab/fix branch April 15, 2020 09:53
@thompsongl thompsongl mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiTabbedContent] Doesn't focus on correct tab when using mouse and initialFocus is selected
4 participants
@ashikmeerankutty @kibanamachine @miukimiu @thompsongl