Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed EuiI8n hasPropName utility errors on null values #3303

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Fixed EuiI8n hasPropName utility errors on null values #3303

merged 3 commits into from
Apr 13, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Apr 12, 2020 •
edited
Loading

Summary

Fixes #3301

  • Added test to render component if the value is null
  • Fixed issue by checking if the child is null then return false

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
    - [ ] Added documentation examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chandlerprall chandlerprall self-assigned this Apr 13, 2020
chandlerprall
chandlerprall approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; Ran the test without the fix to confirm it successfully fails.

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3303/

@chandlerprall chandlerprall merged commit 5e51f38 into elastic:master Apr 13, 2020
@ashikmeerankutty ashikmeerankutty deleted the i18n-fix branch April 15, 2020 09:53
@thompsongl thompsongl mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees

@chandlerprall chandlerprall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hasPropName utility errors on null values
3 participants
@ashikmeerankutty @kibanamachine @chandlerprall