Add panelStyle prop to EuiPopover; Fix EuiTourStep minWidth prop placement
#3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3329/ |
chandlerprall
approved these changes
Apr 16, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3329/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where passing
leftortopas part of the EuiPopoverstyleprop would override its internally calculated position.The passing-through of
styleto the panel of EuiPopover has only been possible since EuiTourStep was introduced. It should have been a new style object prop, asstylewas already used on the basedivelement of EuiPopover.Adding and using the
panelStyleprop solves two problems:minWidthon the panel element only (instead of also settingminWidthon a wrapper element)Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes